19,158 matching drops
#1459158 2026-09-22 15:17
punk6529 Follow The Repo Reply #1080430 2026-06-11 07:49
this does not matter so much, if the bots have app and AWS CLI access to the staging environment/vpc/etc they grind it out in the logs and figure it out
Context from GelatoGenesis #1080426 2026-06-11 07:48
and i imagine if constant staging merges and redeploys auto-happen then it's a bit hard to report which actual version "caused a problem". but this might not be as big of an issue as it first seems
punk6529 Follow The Repo #1080428 2026-06-11 07:48
and anything we can do to make the deployments faster is important
punk6529 Follow The Repo #1080427 2026-06-11 07:48
yes for this to work staging need to stay up during deployments
punk6529 Follow The Repo #1080424 2026-06-11 07:48
the bots have spent all weekend fixing at least the obvious things they broke on staging
punk6529 Follow The Repo #1080423 2026-06-11 07:48
at least before I handed over my work to the professionals
punk6529 Follow The Repo #1080422 2026-06-11 07:47
is working on a common code base
punk6529 Follow The Repo #1080421 2026-06-11 07:47
if they are at least merged, then anyone starting work on something new on Monday
punk6529 Follow The Repo #1080420 2026-06-11 07:47
so we need to solve each step of the process at a time
punk6529 Follow The Repo #1080418 2026-06-11 07:46
it is going to be Conflict Central
punk6529 Follow The Repo #1080416 2026-06-11 07:46
we will collapse into chaos, we won't know what branch to work on
punk6529 Follow The Repo #1080415 2026-06-11 07:46
and now we are waiting for you too look at each one before even merging
punk6529 Follow The Repo #1080414 2026-06-11 07:46
there are 200 PRs unmerged
punk6529 Follow The Repo #1080413 2026-06-11 07:46
we can't have a situation where you come in on Monday
punk6529 Follow The Repo #1080412 2026-06-11 07:46
this is weeks away not months away here
punk6529 Follow The Repo #1080411 2026-06-11 07:46
from trivial (sure, some), but also normal and some serious ones
punk6529 Follow The Repo #1080410 2026-06-11 07:45
across multiple parts of the app
punk6529 Follow The Repo #1080408 2026-06-11 07:45
between Friday night and Monday morning, I pushed 290 PRs
punk6529 Follow The Repo #1080407 2026-06-11 07:45
I had a weekend where I wanted to push some things forward materially
punk6529 Follow The Repo #1080406 2026-06-11 07:45
still a bit dangerous, but less dangerous
punk6529 Follow The Repo #1080405 2026-06-11 07:44
and I know the repo much better so I am less dangerous
punk6529 Follow The Repo #1080404 2026-06-11 07:44
two weekends ago, on the other repo, where all my tooling is more mature
punk6529 Follow The Repo Reply #1080403 2026-06-11 07:44
yes this is exactly the way
Context from GelatoGenesis #1080401 2026-06-11 07:43
so the middle ground is "release branches". we merge the pr's we deem safe-to-deploy to release branches and then merge those from time to time.
punk6529 Follow The Repo #1080402 2026-06-11 07:44
I want to get you all in the right mood of what the "very near future looks like"
punk6529 Follow The Repo #1080400 2026-06-11 07:43
as I had mentioned a few weeks ago, I speak from painful experience, I have gone through this whole cycle on a different repo starting in January and have 100% certainty how it will play out
punk6529 Follow The Repo #1080397 2026-06-11 07:43
because then we are creating new future issues from ourselves
punk6529 Follow The Repo #1080396 2026-06-11 07:42
and even with staging in place, it is important that production does not fall 420 commits behind
punk6529 Follow The Repo #1080395 2026-06-11 07:42
so it is neither going to be 1 at a time nor 'all of staging'
punk6529 Follow The Repo #1080394 2026-06-11 07:42
but 8 was a big change in how we handle wallets, let's give it another look tomorrow, all of us with a fresh mind
punk6529 Follow The Repo #1080393 2026-06-11 07:41
a lot of them will be relatively straightforward and harmless and with tools to help review them, a human review will allow you to say: yup, deployments 1 to 7, 9, 12, 14,15,16 seem ok, lets get them to prod
punk6529 Follow The Repo #1080390 2026-06-11 07:40
what this looks like at "today's scale" not "tomorrow's scale" is that we might have 10-30 deployments per day to staging
punk6529 Follow The Repo Reply #1080389 2026-06-11 07:40
i think we are going to have to cherry pick what goes from staging to prod
Context from GelatoGenesis #1080385 2026-06-11 07:39
so the plan is that bots constantly deploy to staging and then at some point we merge staging to production? or we still merge dev branch to production after bots have finished testing it to staging?
punk6529 Follow The Repo #1080388 2026-06-11 07:40
the exact same reasons apply here
punk6529 Follow The Repo #1080386 2026-06-11 07:39
could you @[simo] do a good job developing if you could never deploy any of your work to staging to see what you did? would it improve or worsen your coding?
punk6529 Follow The Repo #1080384 2026-06-11 07:39
the way to maximize their performance is to treat them like a human
punk6529 Follow The Repo #1080383 2026-06-11 07:39
in time though (and I have done it, so I am speaking from experience), they are good enough even to handle db migrations and test them (on staging)
punk6529 Follow The Repo #1080382 2026-06-11 07:38
we can start with the FE, where it less sensitive
punk6529 Follow The Repo #1080381 2026-06-11 07:38
and so we need tooling to avoid that
punk6529 Follow The Repo #1080380 2026-06-11 07:38
bc once we make this change, you will proceed to get lost in the deployments
punk6529 Follow The Repo #1080379 2026-06-11 07:37
this is going to need significantly more sophisticated workflows and tooling than you guys have now
punk6529 Follow The Repo #1080377 2026-06-11 07:37
human review comes in part 5 and is the gating factor for now to go to production
punk6529 Follow The Repo #1080376 2026-06-11 07:37
1/ bots E2E test their work on staging 2/ once bot says "we are good" 3/ we have some other specialized bots that also check repeating issues e.g. security, performance, etc (all this means that staging has to become a realistic environment with actual data) 4/ #3 reviewers may be send them back to #2 5/ once everyone is happy, then the bots keep a list that shows the various commits/deployments, rank them by blast radius, risk, what was touched, testing strategy
punk6529 Follow The Repo #1080374 2026-06-11 07:35
I actually think the end-state should be something like this tbh
punk6529 Follow The Repo #1080373 2026-06-11 07:35
that now you are going to have to manually discover
punk6529 Follow The Repo #1080371 2026-06-11 07:34
it would for sure have discovered new things
punk6529 Follow The Repo #1080370 2026-06-11 07:34
could have done an E2E review on staging by itself
punk6529 Follow The Repo #1080369 2026-06-11 07:34
every single PR I have pushed the last 24 hours
punk6529 Follow The Repo #1080368 2026-06-11 07:34
we let them deploy to staging
punk6529 Follow The Repo Reply #1080367 2026-06-11 07:34
the pipeline is very straightforward
Context from simo #1080361 2026-06-11 07:33
i agree, we need some pipeline where agents do their own review and deploying to staging also and testing. what i also see already. doing currently 7 parallel. they are boring, i start to cut corners already etc
punk6529 Follow The Repo #1080365 2026-06-11 07:34
and they should do those before human review